Open jacobwegner opened 1 year ago
Made a good start on this today and hope to circle back next week.
I was thinking about this over the weekend, and while the token would be the preferred level of granularity, there would be some additional work to expand the mapping for all ~3700 annotations we currently have loaded.
A simpler, "coarser" approach would be to inges the ROIs and attach them to the scholia annotations.
Clicking a line in the sidebar would trigger the "highlight" for the lines of text and the scholia URNs, based on the urn:cite2:hmt:va_dse.v1.passage
attribute:
urn:cite2:hmt:va_dse.v1:il15666
DSE record for Iliad 24.804
urn:cts:greekLit:tlg0012.tlg001.msA:24.804
urn:cite2:hmt:vaimg.2017a:VA326VN_0828@0.492,0.6344,0.416,0.0338
urn:cite2:hmt:msA.v1:326v
urn:cite2:hmt:va_dse.v1:schol7480
DSE record for scholion msA 24.105
urn:cts:greekLit:tlg5026.msA.hmt:24.105
urn:cite2:hmt:vaimg.2017a:VA326VN_0828@0.232,0.4137,0.24,0.0405
urn:cite2:hmt:msA.v1:326v
A simpler, "coarser" approach would be to inges the ROIs and attach them to the scholia annotations.
This does seem to be the way to go, so I'll likely spin up a new issue, and also capture some of the feedback from @gregorycrane about selection / navigation issues.
GraphQL Query:
query Scholia($urn: String!, $collectionUrn: ID) {
textAnnotations(reference: $urn, collection_Urn: $collectionUrn) {
edges {
node {
id
idx
data
urn
roi {
urn
coordinatesValue
}
}
}
}
}
Variables:
{
"urn":"urn:cts:greekLit:tlg0012.tlg001.msA-folios:326v.24.795"
}
Resulting JSON:
{
"data": {
"textAnnotations": {
"edges": [
{
"node": {
"id": "VGV4dEFubm90YXRpb25Ob2RlOjQ3NzU=",
"idx": 4774,
"data": {
"lemma": "καὶ τά γε χρυσείην ἐς λάρνακα·",
"dse": {
"urn": "urn:cite2:hmt:va_dse.v1:schol7481",
"imageRoi": "urn:cite2:hmt:vaimg.2017a:VA326VN_0828@0.237,0.4489,0.214,0.0511"
},
"references": [
"urn:cts:greekLit:tlg0012.tlg001.msA-folios:326v.24.795"
],
"comment": "ἡ διπλῆ ὅτι τὴν σορὸν λάρνακα εῖπεν ⁑"
},
"urn": "urn:cts:greekLit:tlg5026.msA.hmt:24.106",
"roi": [
{
"urn": "urn:cite2:hmt:va_dse.v1:schol7481",
"coordinatesValue": "0.237,0.4489,0.214,0.0511"
}
]
}
}
]
}
}
}
Hi @jacobwegner, I also wanted to follow up on this. Is there any way that I could help push this out? Or is it usable if I reference the commit SHA?
@pletcher Let me circle back later today...need to revisit whatever my context was from March 😉
@pletcher Hopefully tomorrow for this and https://github.com/scaife-viewer/beyond-translation-site/issues/100#issuecomment-1589904456 ...I just couldn't get to it today!
No problem, @jacobwegner -- thanks!
@pletcher Circling back...
scaife-viewer
GitHub org, would you mind landing any future commits / branches directly off of the "upstream" repos? That should make it easier to do these "deploy previews".
If you checkout feature/roi-improvements
here, it has the latest commits for the frontend / backend branches.
I was able to rebuild the database and have access to the ROI.
I'll send you a Slack DM that has a tarball you can pull to skip rebuilding the database.
Let me know if you need anything else in the ROI world :-)
Awesome, thank you! And for sure, will do!
Refs #100
TODOs:
12r
to tokens (using msa_scholia_tokens.csv)