scaife-viewer / beyond-translation-site

Site used to iterate on translation alignments within the Scaife Viewer ecosystem
3 stars 4 forks source link

Backport review apps fixes from feature/cambridge-greek-lexicon #159

Closed jacobwegner closed 1 year ago

jacobwegner commented 1 year ago

Refs #158

Verifying these changes:

jacobwegner commented 1 year ago

Ok, progress.

The last build failed, but it did not "nuke" the review app:

 ---> Running in 3990649435c8
yarn run v1.22.5
$ vue-cli-service build
-  Building for production...
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
...
error Command failed with signal "SIGKILL".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command '/bin/sh -c yarn build' returned a non-zero code: 1

I'm thinking that we need to either optimize / increase the memory usage during the build (may not be able to configure Heroku to do so) or use an alternate form of deployment for review apps.

jacobwegner commented 1 year ago

Heroku support indicated that there is indeed a "hard" limit during builds; I'm going to merge these changes in as I think it helps some of the stability, and we can revisit GitHub Actions for handling review app builds automatically in the future.

(GitHub Actions is how we're doing production / staging deploys already)