scaife-viewer / beyond-translation-site

Site used to iterate on translation alignments within the Scaife Viewer ecosystem
3 stars 4 forks source link

Updates to support custom tokenizer and improved RTL display #166

Open jacobwegner opened 1 year ago

jacobwegner commented 1 year ago

This PR lands a few things back to the feature/ibnsaid branch:

Verified locally and in Codespaces:

/reader/urn:cts:arabicLit:amedsaid1831.dw042.perseus-ara1:1?mode=interlinear

image

To review these changes, you'll want to check out the ibnsaid-tokenizer branch in Codespaces and then:

# from backend shell
pip uninstall -y scaife-viewer-atlas
pip install "scaife-viewer-atlas @https://github.com/scaife-viewer/backend/archive/552ee49c150439f96bab9f40b46e822ac452f4d0.zip#subdirectory=atlas"
# from frontend shell
yarn install
jacobwegner commented 1 year ago

@jchill-git I've done this as a PR so you can verify the changes before we merge into your feature branch.

If things are working here, please go ahead and approve and merge this branch.

If things aren't working, please let me know...happy to try and troubleshoot with you!