scaife-viewer / beyond-translation-site

Site used to iterate on translation alignments within the Scaife Viewer ecosystem
3 stars 4 forks source link

Treebank image cut off #50

Closed gregorycrane closed 2 years ago

gregorycrane commented 2 years ago

The image of this treebank cuts out on the right prematurely -- like there was a limit to the x-axis side. https://beyond-translation-gagdt-dev.herokuapp.com/reader/urn:cts:greekLit:tlg0012.tlg001.perseus-grc2:16.623?mode=syntax-trees&entryUrn=urn%3Acite2%3AexploreHomer%3Aentries.atlas_v1%3A1.1673&rs image

jacobwegner commented 2 years ago

There have been quite a few things we've had to fight through with the underlying library we're using to render the trees.

For this particular tree, if you're on a smaller display, you can toggle the sidebars open / shut and that should help prevent text from being clipped:

image image

It is less of an issue on larger displays:

image

I'll try and circle back to see if there is anything else we can do to help, but it might be a limitation that requries us to choose a different rendering library.

jacobwegner commented 2 years ago

@gregorycrane I fought with the library again...should no longer clip:

https://beyond-translation-gagdt-dev.herokuapp.com/reader/urn:cts:greekLit:tlg0012.tlg001.perseus-grc2:16.623?mode=syntax-trees&entryUrn=urn%3Acite2%3AexploreHomer%3Aentries.atlas_v1%3A1.1673&rs

image image
jacobwegner commented 2 years ago

I'll consider this closed