scaife-viewer / explorehomer

front-end for the Scaife "Explore Homer" prototype
https://scaife-viewer.org/
MIT License
4 stars 0 forks source link

Add named entities widget #10

Closed paltman closed 4 years ago

paltman commented 4 years ago

As a user, I can see a list of named entities in the passage

paltman commented 4 years ago

As a user, I can select a named entity in the passage and update the named entities widget to see more detail

paltman commented 4 years ago

As a user, when I select a named entity occurrence in the text, all of the other occurrences are highlighted, and the selection in the widget is updated

jacobwegner commented 4 years ago

Again, due to a lagging bug with scaife-widgets, this is a good preview URL:

https://deploy-preview-10--explorehomer-dev.netlify.app/reader?urn=urn%3Acts%3AgreekLit%3Atlg0012.tlg001.perseus-grc2%3A1.1-1.7

jacobwegner commented 4 years ago

@paltman I've just updated develop with the latest scaife-widgets; if you pull those changes in, that should resolve the console error.

paltman commented 4 years ago

@jacobwegner I think this is ready for another review. I've addressed the two asks by @jtauber (I think I did them right) and cleaned up other UI issues I remember us talking about.

jacobwegner commented 4 years ago

@paltman thanks.

re: #1 above, the 'selection' green works great once you've selected an entity, but what about styling the unselected tokens when in named entity mode?

We style tokens that have references to named entities

(with the idea being that when in named entity mode, you can see where all of the entities are in the text at a glance, and then make selections to see more info in the widget).

jacobwegner commented 4 years ago

re #2 above, I don't think this has been resolved yet.

Below, when I select the last token on line 7 in "default" mode, the other named entity instances are also selected

paltman commented 4 years ago

@jacobwegner ok, ready for another review :)

paltman commented 4 years ago

Token styling improvements

paltman commented 4 years ago

Ensure consistent size for input fields

paltman commented 4 years ago

Ensure consistent typefaces