scaife-viewer / explorehomer

front-end for the Scaife "Explore Homer" prototype
https://scaife-viewer.org/
MIT License
4 stars 0 forks source link

Add default failbacks #37

Closed paltman closed 4 years ago

paltman commented 4 years ago

Add fallback messages when no data is returned for a given annotation

jtauber commented 4 years ago

The first thing that's clear is that we're completely inconsistent in the styling of the widget fallback.

My slight preference is the Named Entities variant. I certainly prefer the smaller font size, less indentation, and no period.

Not sure what which I prefer between "available" or "found" or neither.

paltman commented 4 years ago

I'll make a component called <EmptyMessage> that can have it's own single style.

paltman commented 4 years ago

@jtauber everything is now the same font/size/padding/message. It's a default message in a slot so we can override with specific language. Just let me know what language you want in what widget/place.

jtauber commented 4 years ago

For the side widgets, I'd drop the text-align: center; and change the padding to padding: 0 0 0.4rem;

I understand the centering and margins are needed when in the reader widget (metrical annotation and folios) but in side widgets they take up a bit too much space and draw too much attention.

paltman commented 4 years ago

@jtauber fixed