scaife-viewer / explorehomer

front-end for the Scaife "Explore Homer" prototype
https://scaife-viewer.org/
MIT License
4 stars 0 forks source link

Add urn keys to reference widgets #61

Closed paltman closed 4 years ago

paltman commented 4 years ago

On reference widgets, make use of component keys to prevent redraw issues

paltman commented 4 years ago

@jacobwegner I did them all except for the new Alexandria widget. That one is done a bit differently than others as it's extending from the widgets package instead of just copying it in. I wasn't sure if you were ok with me copying it in and managing the manual merge with the extended bits so that I could key it. I don't know of another way to key it but wasn't sure if there was a special reason for extending instead of copying in that I'm missing.

jacobwegner commented 4 years ago

@paltman: Can we do a port of the NAC widget and then rename the existing widget as EHNAC widget?

We wanted to override the query for the Folio URNS:

https://github.com/scaife-viewer/explorehomer/pull/46

paltman commented 4 years ago

Done

jacobwegner commented 4 years ago

@paltman I went and refactored your port just a bit:

jacobwegner commented 4 years ago

Fix data issue with NAC widget

jacobwegner commented 4 years ago

replaced via https://github.com/scaife-viewer/explorehomer/pull/67