Open jacobwegner opened 4 years ago
@paltman I've got a new deploy up:
Pedantically, the textParts
relation is including 12r, 12r.1, 12r.1.1, 12r.1.2
, etc. I'm still mulling around this.
Looping back to our discussion, I'd still think you'd want to do two queries:
And then you could flatten textParts
from the image annotations and map the refs from the text parts to "group" the passage text parts within each image annotation.
Take a look, and if you would rather see additional changes on the server, I'm open to discussing it further.,
This isn't ready yet; requires an ATLAS data model change
@jtauber this can be reviewed via http://deploy-preview-47--sv-mini.netlify.app/reader/urn:cts:greekLit:tlg0012.tlg001.msA-folios:12r-13v?mode=folio
What happens:
When viewing passage reference 12r-14v, all of the text parts are shown, but only the first folio image is shown:
When paginating to 15r-17v, the first folio image is shown
What I'd expect to happen:
Show multiple folios, with the text parts "grouped" into a text part / folio row.
(The
ImageAnnotations
query could even return the relevant text parts, rather than having to build something up client-side:https://github.com/scaife-viewer/frontend/blob/master/packages/reader-image-mode/src/ImageModeReader.vue#L72 )