scaife-viewer / frontend

Skeleton, Widgets, and other frontend packages for the Scaife Viewer
0 stars 3 forks source link

Defining default colors for links #3

Closed jacobwegner closed 4 years ago

jacobwegner commented 4 years ago

@paltman: I've been experimenting with the frontend "demo" packages as part of and noticed that the "demo mode" here falls back to the browser defaults for link colors:

image

vs Explore Homer:

image

https://github.com/scaife-viewer/explorehomer/blob/3f50dcc83a2a968059719b7fb2cb05069e5aef7d/src/App.vue#L47

I'd suggest we take that into consideration as part of using "theming" using these packages in scaife-viewer/explorehomer.

There are places (in the siblings widget and library) using the browser colors and other places (the folio images mode) where we've defined the default as the "accent" color used in EH.

paltman commented 4 years ago

Thanks for creating the issue. Thus a few other bits have slipped through now that we don’t have global styles defined in EH that are top of mind to get back to on a “detail” pass.

On Aug 12, 2020, at 4:13 PM, Jacob Wegner notifications@github.com wrote:

 @paltman: I've been experimenting with the frontend "demo" packages as part of and noticed that the "demo mode" here falls back to the browser defaults for link colors:

vs Explore Homer:

https://github.com/scaife-viewer/explorehomer/blob/3f50dcc83a2a968059719b7fb2cb05069e5aef7d/src/App.vue#L47

I'd suggest we take that into consideration as part of using "theming" using these packages in scaife-viewer/explorehomer.

There are places (in the siblings widget and library) using the browser colors and other places (the folio images mode) where we've defined the default as the "accent" color used in EH.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.