search

scaife-viewer / frontend

Skeleton, Widgets, and other frontend packages for the Scaife Viewer
0 stars 3 forks source link

Fix bug with token alignment highlighting #46

Closed jacobwegner closed 2 years ago

jacobwegner commented 3 years ago

Between 0.0.9 and 0.0.10, we are now indicating that all tokens have multiple alignments (red/green):

https://github.com/scaife-viewer/frontend/compare/@scaife-viewer/reader-alignments-mode@0.0.9...@scaife-viewer/reader-alignments-mode@0.0.10

0.0.9: https://sv-mini-dev.scaife-viewer.org/reader?urn=urn%3Acts%3AgreekLit%3Atlg0012.tlg001.perseus-grc2%3A1.1-1.7

0.0.10: https://deploy-preview-47--sv-mini.netlify.app/reader/urn:cts:greekLit:tlg0012.tlg001.perseus-grc2:1.1-1.7?mode=alignments&rs=urn%3Acite2%3Ascaife-viewer%3Aalignment.v1%3Ailiad-word-alignment

jacobwegner commented 3 years ago

image

vs

image

I'll research to rule out a data issue

jacobwegner commented 3 years ago

Doesn't appear to be a data issue, as both deployments are pointing to the same ATLAS endpoint (https://sv-mini-atlas-dev.scaife-viewer.org/graphql/)

jacobwegner commented 3 years ago

@jtauber this has been fixed if you can verify on the following URL:

https://scaife-viewer-frontend.netlify.app/explore-homer/urn:cts:greekLit:tlg0012.tlg001.perseus-grc2:1.12?mode=alignments

https://share.getcloudapp.com/NQu1BzYK

jacobwegner commented 3 years ago

(once verified I'll move along with the release and deployment)