search

scaife-viewer / frontend

Skeleton, Widgets, and other frontend packages for the Scaife Viewer
0 stars 3 forks source link

Feature/regions of interest #65

Closed pletcher closed 1 year ago

pletcher commented 1 year ago

This is a first stab at bidirectional regions of interest for the Venetus A folios (or any mss. where we have ROI data).

Readers can click the highlight icon next to a line ref to draw a box around the line in the manuscript; or they can click the highlight icon above the OSD viewer, then click one of the lines in the image to highlight the corresponding transcription on the left.

@jacobwegner I would love feedback if/when you have a chance! I tried to reuse existing code/infrastructure as much as possible, but I don't know the app well enough to know everywhere I might have done something amiss.

I'm also more than happy to tweak the design/UI/UX -- design isn't my strong suit, so I just went with things that seemed relatively intuitive/discoverable for me as a reader.

Thanks!

pletcher commented 1 year ago

Oof, sorry about the yarn.lock noise -- yarn just did that automatically. I can exclude it from this PR if needed.

Separately, I removed the WIP tag -- I think this is ready for review!

jacobwegner commented 1 year ago

@pletcher Hoping to take a closer look at this early next week...apologies for the delay!

jacobwegner commented 1 year ago

Short recording showing bi-directional functionality:

Screen Recording 2023-02-06 at 2 50 24 PM 2023-02-06 14_53_49