scaife-viewer / scaife-skeleton

front-end layout library for Scaife readers
https://scaife-viewer.org/
MIT License
2 stars 0 forks source link

bring back responsive sidebar overlay #24

Open jtauber opened 5 years ago

jtauber commented 5 years ago

Like Perseus Scaife, sidebars should overlay rather than push at narrow screen widths.

mjhea0 commented 5 years ago

Have you thought about maybe combining them into a single sidebar for mobile views?

jtauber commented 5 years ago

@mjhea0 no, but that's brilliant. There were reasons not to do it in the current Scaife but with this new skeleton approach, your suggestion is probably the way to go.

It might complicate skeleton config, although to be honest I haven't even considered skeleton config on narrow screens yet.

jacobwegner commented 4 years ago

I came across this issue while looking into backporting scaife-viewer #407.

Here are some screenshots comparing current scaife with the skeleton at various resolutions:

Phone scaife-phone

skeleton-phone

Tablet

scaife-tablet

skeleton-tablet

Laptop

scaife-laptop

skeleton-laptop

Desktop

scaife-desktop

skeleton-desktop