URN Refactor

[jhrr]

• Refactors throughout the project to complete using the new URN utility everywhere.
• Expands the functionality of the URN utility.
• Eliminates the noisier parts of URN munging in CTSImporter and tests, relocating that labour as much as possible in the URN class itself.
• Unittest and fuzztest the URN class.
• Refactor the test suite for CTSImporter.
• Add coverage to the project.

[jhrr]

very good, thanks!

On Tue, Jan 21, 2020 at 9:37 PM Jacob Wegner notifications@github.com wrote:

@jacobwegner approved this pull request.

In sv_mini_atlas/library/urn.py https://github.com/scaife-viewer/sv-mini-atlas/pull/3#discussion_r369230093 :

• if key == self.NO_PASSAGE and self.parsed["work"]:
• return value

• TODO: Is there any time we don't want a trailing ":" for any URN

Agreed; this might have been cruft from the earlier backport I did. Remove at will!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scaife-viewer/sv-mini-atlas/pull/3?email_source=notifications&email_token=AAK5LYTMUGYQL23V7YK4W53Q65MIZA5CNFSM4KJYWK7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSRDIPY#pullrequestreview-346174527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK5LYX5AGOKGEXCETTVODDQ65MIZANCNFSM4KJYWK7A .