scaife-viewer / sv-mini-atlas

ATLAS implementation for the Scaife "SV Mini" prototype
https://scaife-viewer.org/
MIT License
1 stars 1 forks source link

Library Widget #5

Closed jhrr closed 4 years ago

jhrr commented 4 years ago

Notes

As a result of the first point above (dealing with more library-side/meta URN values) I've noticed our URN.py and URN.js utilities are lagging behind a bit and neither can parse a 'partial' URN like urn:cts:greekLit:, for example. This was fine up to now as we were only really dealing with full passage URNs, but as we move further up the tree the implementations are starting to fail. The JavaScript version is particularly in need of some attention and it would be good if we implemented an analogous method as up_to in there. I looked into fixing this up during the week but considering time demands it was larger of a job than I wanted to add to my plate and it would be nice to do it properly. I have an entire checklist of various URN abstraction related points that I'd like to make into a ticket, and as I mentioned to @jtauber maybe these could be done alongside the CTS URN widget, which still needs to be ported.

Related PRs

jacobwegner commented 4 years ago

@jhrr I've approved this PR; I think there are definitely more conversations to be had to help shape the "library" use case and improving our URN toolset as you've alluded to (have a URN.py and URN.js card in Trello that I've linked your PR body to as a TODO)

jhrr commented 4 years ago

@jacobwegner yep I agree, the space around this is definitely opening up but I also feel there is still lots of refinement to be made. Thanks for the review!