scailable / sclblpy

Python package for Scailable uploads
MIT License
19 stars 1 forks source link

F/update tutorial #48

Closed wooohoooo closed 2 years ago

wooohoooo commented 2 years ago
wooohoooo commented 2 years ago

Thanks for starting the refactor, super! The tests have not been refactored yet, if I am not mistaken? There are also some spelling errors in the Python Notebook, (ie delte model --> delete model), good to check for them before the next commit.

Heyhey! no, as I mentioned, there is no real refactor so far. I made a notebook to make sure I can test the workings of the package since the tests aren't very useful at this point; and as a second use, that notebook can be used as an example :)

Refactor is starting now as (in slack) it's been cleared that the relevant functions are being covered by the notebook.

Thanks for the review!