scailable / sclblpy

Python package for Scailable uploads
MIT License
19 stars 1 forks source link

F/remove sklarn #49

Closed wooohoooo closed 2 years ago

wooohoooo commented 2 years ago
ayoub-assis commented 2 years ago

Everything looks fine to me. Albeit I couldn't run the notebook and test files since I don't have an account with a device. But maybe that's something that is irrelevant to this PR. @robinvanemden

MKaptein commented 2 years ago

You should definitely setup your own account and create a device so you can test!

On 10 May 2022, at 09:56, ayoub-assis @.***> wrote:

Everything looks fine to me. Albeit I couldn't run the notebook and test files since I don't have an account with a device. But maybe that's something that is irrelevant to this PR. @robinvanemden https://github.com/robinvanemden — Reply to this email directly, view it on GitHub https://github.com/scailable/sclblpy/pull/49#issuecomment-1122054431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGHUD44BM42NMX2YSK3TT3VJIJDTANCNFSM5VIG7IVA. You are receiving this because you are subscribed to this thread.

ayoub-assis commented 2 years ago
ayoub-assis commented 2 years ago

Manual Testing

ayoub-assis commented 2 years ago
robinvanemden commented 2 years ago

Works for me locally. All issues that were found were also resolved by @ayoub-assis . Merging.