search

scakemyer / plugin.video.quasar

Quasar add-on for Kodi
https://quasar.surge.sh/
346 stars 94 forks source link

Option "Choose stream automatically" does not work for the latest TV Show episode #745

Closed heartlogic closed 7 years ago

heartlogic commented 7 years ago

I try to choose stream manually and i can't.

Expected Behavior

When we disable option "Choose stream automatically" at the torrent search we should have a list of active torrents to nanually choose. Please note that this is happening only on the latest episode of a TV Show. In the old ones this option is working alright.

Current Behavior

Now either way, enabled or disabled, a stream is being automatically chosen.

Possible Solution

Steps to Reproduce (for bugs)

Just try to watch the latest episode of a TV Show with this option disabled.

Your Environment

scakemyer commented 7 years ago

It's working perfectly fine here. My guess is that you're playing from library integration, which gets its .strm files written according to your setting at that time, which was to automatically choose stream, in which case we should get rid of writing /play or /links in strm files, and use a different URI in those to allow us to respect the current setting no matter what it was set at when the library got updated.

elgatito commented 7 years ago

I was just investigating links/play definotion in strm files. Why it's there if we always get to navigation.py which can get current setting and act accordingly.

scakemyer commented 7 years ago

Because that's how it was implemented initially by i9, and I didn't think about that possible side-effect when I refactored the library integration last month. It's also not something that should be handled in navigation.py either but in the daemon.

heartlogic commented 7 years ago

Yes, you are right. I always use Kodi library to start watching videos.

scakemyer commented 7 years ago

For now, delete the strm file in question, update the library and that should fix it. Will have a proper fix for this in the next release.

scakemyer commented 7 years ago

I really have to apologize to i9; he had implemented that correctly and I'm the one that over-simplified and messed it up during the refactor.