search

scala-academy / performance-analysis

This is a project to be used in the "Scala and akka in practise" course
Other
5 stars 3 forks source link

Feature/ruud #11 [WIP] #36

Closed ruud closed 8 years ago

ruud commented 8 years ago

closes #11

jordi133 commented 8 years ago

I put a comment on the user story "Acceptance test should be implemented in LogSubmissionTest.scala". Did you forget this?

ruud commented 8 years ago

Just changed test to LogSubmissionTest.scala

jordi133 commented 8 years ago

My comment on the user story was:

Acceptance test should be implemented in LogSubmissionTest.scala. Keep in mind that unit testing for the HTTP routes should be done in LogReceiverSpec similar to AdministratorSpec

Both unit tests and integration tests are usefull to add. In a unit test you can look at the specifically the route, just as you have done using the ScalatestRouteTest. In the integration test, the idea is to just start the application and approach the application just as it would be approached in production, through a http-call to the server.

ruud commented 8 years ago

Ok, that is clear. Will add an integration test.