search

scala-hamsters / hamsters

A mini Scala utility library
Apache License 2.0
291 stars 23 forks source link

Retry.withWait should use scala.concurrent.blocking #71

Closed tabdulradi closed 6 years ago

tabdulradi commented 7 years ago

Hello all,

Thanks all for this lib, keep it up!

Retry.withWait could wrap the Thread.sleep inside a blocking block, which warns the global execution context (so that it might add more threads).

Also I'd appreciate make it clearer in the docs that the method blocks a Thread.

loicdescotte commented 7 years ago

Thanks we will look at this!