scala-ide / scala-refactoring

A library providing automated refactoring support for Scala.
http://scala-refactoring.org/
Other
69 stars 47 forks source link

Special treatment for self references #175

Closed mlangc closed 7 years ago

mlangc commented 7 years ago

Self references need special treatment since their representation in typed ASTs is incomplete. This PR takes care of this for Rename and MarkOccurrences. See #1002803 as well as https://github.com/scala-ide/scala-ide/pull/1132.

ghprb-bot commented 7 years ago

Test PASSed.

ghprb-bot commented 7 years ago

Test FAILed.

mlangc commented 7 years ago

Hmm... I just added a comment! Retest this please!

ghprb-bot commented 7 years ago

Test PASSed.

ghprb-bot commented 7 years ago

Test FAILed.

ghprb-bot commented 7 years ago

Test FAILed.

ghprb-bot commented 7 years ago

Test FAILed.

mlangc commented 7 years ago

There seems to be an issue with the 2.12.x related tests that have nothing to do with this PR...

kiritsuku commented 7 years ago

LGTM