Fix "Open Type Hierarchy"

[mlangc]

This pull request fixes a bug with "Open Type Hierarchy" and improves support for Scala objects.

@dragos I'll rebase as soon as ca4451bbb2d49765fe0b0be5de61c735c8fbd7e0 is merged to master.

[ghprb-bot]

Can one of the admins verify this patch?

[misto]

add to whitelist

[misto]

ok to test

[kiritsuku]

LGTM. A further improvement would be to show the package after the class name. At the moment it is not possible to distinguish types with the same name.

[kiritsuku]

ok to test

[kiritsuku]

@dragos I don't have merge rights for this repo. Would you please assign them to me? Furthermore, should we block all merging until 4.0 is released or do you use another branch for the release anyway? Last but not least, who can communicate with ghprb? Are commit rights required or does it require another authorization?

[mlangc]

@sschaef I'll see if I can add tooltips showing the fully qualified class names.

[dragos]

Awesome! thanks for these fixes. As I said, even though nobody is really working on this plugin, we are keeping it up to date w.r.t. to core, and I believe it has great potential. It just needs some love.

[dragos]

@sschaef I just added the committers team to this repo as well.

My take is to not block the PR queue anymore and merge, and an eventual RC3 we'll build from a branch. For this particular fix, I'd actually include it in the release (not least, because of the ignore commit).

[dragos]

@sschaef Feel free to merge when you think it's good to go.

[dotta]

Awesome! thanks for these fixes. As I said, even though nobody is really working on this plugin, we are keeping it up to date w.r.t. to core, and I believe it has great potential. It just needs some love.

+100!!

Thanks @mlangc!

[mlangc]

I'm happy to help! Hopefully I can do more in the future ;-).

[kiritsuku]

@dragos Would you please verify the PR for ghprb?

[dragos]

add to whitelist

[dragos]

@sschaef, @misto I added you to admins for all projects.

[ghprb-bot]

Test FAILed. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-validator/51/

[mlangc]

Hmm, this looks like a problem with the build server to me but I'll double check that tomorrow:

java.io.IOException: remote file operation failed: /localhome/jenkinside/workspace/ghprb-scala-search-for-ide-master-2.11.x/scala-search at hudson.remoting.Channel@725b29e0:typesafe-a1 at hudson.FilePath.act(FilePath.java:916) at hudson.FilePath.act(FilePath.java:893) [...] at hudson.model.Executor.run(Executor.java:231)

[mlangc]

Darn, I think I've forgot to add a file before committing; I'll fix that in the evening.

[mlangc]

Hmm, looks like Jenkins has a problem: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-validator/

[dotta]

@mlangc I don't know what's happening w/ Jenkins. Let's ping @dragos

[mlangc]

@dragos Can you take a look at Jenks? I think it has problems executing the merge build...

[dotta]

@mlangc Sorry for the delay, but the whole Typesafe team was away last week. Coincidentally, I've figured out how to reboot the Jenkins machine, hence you should get feedback on your PR soon.

[ghprb-bot]

Test PASSed.

See Console Output in the link below for an update site containing this PR binary artefacts.

Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-validator/52/

[ghprb-bot]

Test PASSed.

See Console Output in the link below for an update site containing this PR binary artefacts.

Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-validator/53/

[kiritsuku]

LGTM