search

scala-ide / scala-search

Next Scala Search Engine
6 stars 10 forks source link

Upgrade lucene to 5.3.1 #109

Closed andrey-ilinykh closed 8 years ago

dotta commented 8 years ago

@andrey-ilinykh Nice work! LGTM

dotta commented 8 years ago

@sschaef Is it normal that we see no feedback that the PR validation is in progress?

kiritsuku commented 8 years ago

No, that is not normal. Can't check Jenkins right now, I'm behind a proxy that doesn't allow me to access it. I'm going to check it later.

ghprb-bot commented 8 years ago

Refer to this link for build results (access rights to CI server needed):

https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-validator/56/ https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-for-ide-master-2.11.x/58/

andrey-ilinykh commented 8 years ago

I agree , name is not right. I renamed it. It does not have any side effect. It is just a deeper check if the index is in a good state. There is no any reasonable way to handle an error except to rebuild everything. So, I think to return just Boolean is OK.

ghprb-bot commented 8 years ago

Refer to this link for build results (access rights to CI server needed):

https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-validator/57/ https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-search-for-ide-master-2.11.x/59/

kiritsuku commented 8 years ago

LGTM