scala-ide / scala-search

Next Scala Search Engine
6 stars 10 forks source link

Stores occurrences of methods in Lucene #19

Closed mads-hartmann closed 11 years ago

mads-hartmann commented 11 years ago

The plugin now keeps an Index (using Lucene) of all the places methods are mentioned in the code-base. A separate Lucene index is created on disk for each project.

The initial indices will be created upon start-up if no index exists already. It will index the entire workspace and traverse the parse-tree of all Scala sources.

For each project in the workspace we create a background job that continuously update the index and re-index files that have changed.

There are two separate tests: OccurrenceCollectorTest contains test that make sure we record the correct information from the parse trees and IndexTest that makes sure the occurrence information can be stored and retrieved from Lucene.

Fix #1001602

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/11/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/11/
sad kitty

mads-hartmann commented 11 years ago

So, seems like I didn't get the version in the MANIFEST quite right. @dotta any idea?

dotta commented 11 years ago

Yeah, I need to check what's wrong there. I'll push a commit for fixing it somewhere. For the moment, just ignore the failure :)

dotta commented 11 years ago

@mads379 PR #20 should fix the issue with the PR validators (and SHA 41c6a97a5781d35415fdc04557cf831cd5aa66af should no longer be needed...)

dotta commented 11 years ago

@mads379 Could you add a couple of tests for the using module. I really haven't tested it, so it's good to make sure it does what's supposed to do :)

Otherwise, this looks good to me. @dragos, how does it look on your side?

dotta commented 11 years ago

As Iuli pointed out, we should use Eclipse IResource instead of absolute paths. What I suggest is that we create a ticket and we tackle this in a different PR. Ok?

You can read about Eclipse IResource here

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/11/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/11/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/11/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/11/
sad kitty

dotta commented 11 years ago

Alright, I've merged #20, now both PR validator should work fine.

@mads379 I believe your PR is ready for inclusion. What you should do now is rebasing your branch on the latest master (because this PR can no longer be cleanly merged) and squash/amends commit as you think it makes sense. When you are done, just force push your branch and if all is good it will get merged :)

mads-hartmann commented 11 years ago

PLS REBUILD ALL

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/14/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/14/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/14/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/14/

mads-hartmann commented 11 years ago

Yay! :)

dotta commented 11 years ago

Congratulations for this really awesome PR!

Keep up the good work.