1001621 Improved tree traversal - Githubissues

scala-ide / scala-search

Next Scala Search Engine

6 stars 10 forks source link

1001621 Improved tree traversal #23

Closed mads-hartmann closed 11 years ago

mads-hartmann commented 11 years ago

This fixes three issues

The code used super.traverse to recurse the trees. This was wrong as it would skip one 'layer' of nodes.
Traverse the argument list of DefDef's
Store occurrences in ValDefs

So it turned out that the failure that was seen with the string interpolation test had nothing to do with string interpolation.

Originally it only found one occurrence of x in the following example.

def foo(x: String) = s"Hi there, ${x}"

I assumed that the x that was missing was the one inside of the string interpolation, but actually it was the argument. Ups.

Fix #1001621

mads-hartmann commented 11 years ago

@dragos | @dotta This is ready for reviewing :)

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/23/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/23/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/24/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/24/

mads-hartmann commented 11 years ago

@dragos Removed the explicit super and it now indexes annotations as well :)

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/26/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/26/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/26/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/26/

dragos commented 11 years ago

I love it when I'm right! :sunglasses:

LGTM!

mads-hartmann commented 11 years ago

It's the second time you've looked at the tree traversal and found an issue ;)

mads-hartmann commented 11 years ago

Squashed commits. Should be good to merge. :+1:

dragos commented 11 years ago

Sorry, I didn't realize I have to merge it myself! Done!

mads-hartmann commented 11 years ago

Thanks! If you want to lessen @dotta's code-review burdon for tomorrow you can review https://github.com/scala-ide/scala-search/pull/22 as well ;)