Find occurrences of methods misses cases

scala-ide / scala-search

Next Scala Search Engine

6 stars 10 forks source link

Find occurrences of methods misses cases #38

Closed dragos closed 11 years ago

dragos commented 11 years ago

Using the sdt.core project, I searched for askOption, starting from its definition in ScalaPresentationCompiler. I noticed that:

it only finds 4 occurrences in SafeSymbol.scala, there are 5 (the one at line 97 is missing). If I search starting from that occurrence, it finds all 5 of them
sometimes it finds only one occurrence in ScalaLaunchShortcut.scala, out of the 2. Sometimes it finds both

mads-hartmann commented 11 years ago

This is very funky. Mine doesn't even show the results in SafeSymbol.scala. When I start at the one in SafeSymbol.scala it does show the definition though. I'll investigate :)

mads-hartmann commented 11 years ago

Ah, it seems to be related to #39. The importer throws an exception before it can find all the results! :)

mads-hartmann commented 11 years ago

There were at least two problems going wrong here. First off because of #39 an exception would be thrown and it would stop the search.

When that was fixed, I hit a bug in compiler: Sometimes askOption will return an overloaded symbol rather than the symbol of the method that is being used at the given point. This resulted in our comparison failing.

dragos commented 11 years ago

Yeap, the overloaded-symbol bug is annoying, I'll have a look.