search

scala-ide / scala-search

Next Scala Search Engine
6 stars 10 forks source link

1001755 find subclasses #61

Closed mads-hartmann closed 11 years ago

mads-hartmann commented 11 years ago

I've not squashed commits yet as it might make it easier to review.

It's a rather big one, sorry about that :)

dotta commented 11 years ago

@mads379 Could you push all changes you do as an additional commit, that way it's easier to see the delta. Thanks!

mads-hartmann commented 11 years ago

@dotta I've pushed my changes as a new commit, but since you're away I'll find someone else to review them :) /hint @dragos ;)

mads-hartmann commented 11 years ago

PLS REBUILD/scala-search-master-2.10-pr-validator@5828d99

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19896178) :cat: Roger! Rebuilding scala-search-master-2.10-pr-validator for 5828d991. :rotating_light:

mads-hartmann commented 11 years ago

NO LITTER! PLS REBUILD ALL

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19907831) :cat: Roger! Rebuilding scala-search-master-2.10-pr-validator, scala-search-3.0.x-2.10-pr-validator, scala-search-master-2.11-pr-validator for 2c9d4e81, 1e58d532, 5828d991, d1537dd9, 30a3140e, 4c4b31cb, f5acbdcb. :rotating_light:

mads-hartmann commented 11 years ago

I don't know why the validator is hanging but if you check the logs you can see that it was successful.

dragos commented 11 years ago

LGTM. (I only looked at the last commit)

mads-hartmann commented 11 years ago

@dragos That should be good enough! @dotta is very thorough so the rest should be good enough :)

mads-hartmann commented 11 years ago

@huitseeker Are you okay with me squashing the commits or are you using them to figure out why the build kitty was acting up yesterday?

dragos commented 11 years ago

You can squash.

mads-hartmann commented 11 years ago

screen shot 2013-06-25 at 3 34 27 pm

huitseeker commented 11 years ago

NOLITTER! BUILDLOG?

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20043707) scala-search-master-2.10-pr-validator:

scala-search-3.0.x-2.10-pr-validator:

scala-search-master-2.11-pr-validator:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20043707) :cat: cleaning up... sorry! :cat:

huitseeker commented 11 years ago

PLS REBUILD/scala-search-master-2.10-pr-validator@f5acbdcb

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20044084) :cat: Roger! Rebuilding scala-search-master-2.10-pr-validator for f5acbdcb. :rotating_light:

huitseeker commented 11 years ago

LGTM

huitseeker commented 11 years ago

PLS SYNCH

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20050593) :cat: Synchronaising! :pray:

mads-hartmann commented 11 years ago

I can't reproduce the build failure locally (ide-nightly using 2.11.x) so I'll merge this :) thanks for the reviews!