search

scala-ide / scala-search

Next Scala Search Engine
6 stars 10 forks source link

Can now distinguish between local vals/vars #63

Closed mads-hartmann closed 11 years ago

mads-hartmann commented 11 years ago

The problem was that we're unifying val/var fields by always comparing the getter symbol. The getter symbol of a local val/var is NoSymbol, hence it would always return true, since NoSymbol == NoSymbol.

The fix is simple. If it's a local val/var we need to treat it differently than a val/var field, and simply compare the using the isSameSymbol logic.

Fixes #1001775

mads-hartmann commented 11 years ago

@dragos @dotta This should be merged before we cut a new release of Scala Search. It's a pretty stupid bug ;)

@huitseeker In case you're curious, see the commit message for what I did wrong ;)

mads-hartmann commented 11 years ago

Build errors are fixed in #64

dragos commented 11 years ago

LGTM