search

scala-ide / scala-search

Next Scala Search Engine
6 stars 10 forks source link

Change junit bundle name in manifest #70

Closed mads-hartmann closed 11 years ago

mads-hartmann commented 11 years ago

This makes sure that we can compile the tests inside of Eclipse on Indigo as well as Juno/Kepler.

dotta commented 11 years ago

LGTM

kiritsuku commented 11 years ago

Mads, did you get the tests to run too? I couldn't find out what's the problem - always getting an exception on startup. Do I need to run them with a specific test category?

mads-hartmann commented 11 years ago

@sschaef The tests needs to be executed using the Equinox Weaving plugin just as with the IDE. The tests run fine in Kepler, but I can see that they don't work from inside of Indigo.

@dotta Is this a problem? It can runs with the different profiles just fine from the command-line but it appears that you need juno/kepler to execute the tests from inside of the IDE (I'm fine with this).

dotta commented 11 years ago

@dotta Is this a problem? It can runs with the different profiles just fine from the command-line but it appears that you need juno/kepler to execute the tests from inside of the IDE (I'm fine with this).

I'm surprised they don't run fine on Indigo (if you have a stacktrace I can take a look and see if it triggers any memory). Either ways, I don't think it's an issue, Scala IDE no longer targets Indigo and development on Scala Search should be done using Kepler.

kiritsuku commented 11 years ago

I execute them with equinox weaving but I get:

java.lang.NoClassDefFoundError: scala/tools/eclipse/logging/StreamRedirect$$anonfun$2$$anonfun$apply$2

All plugins seem to be loaded, have you seen this issue before?

mads-hartmann commented 11 years ago

@sschaef What Eclipse version? I don't remember haven seen that before :/

kiritsuku commented 11 years ago

On 08/05/2013 11:40 PM, Mads Hartmann Jensen wrote:

@sschaef https://github.com/sschaef What Eclipse version? I don't remember haven seen that before :/

I use Kepler and run it with the sources of the IDE. I used 2.10 so far, did you only try it out with 2.11?

mads-hartmann commented 11 years ago

@sschaef Hm okay. I use scala 2.10 and they run just fine inside of Kepler for me :/ Can you run them using ./build.sh?

kiritsuku commented 11 years ago

Yes, on the shell everything works fine. I'll run the tests there for the moment - not very comfortable but better than no tests at all.

mads-hartmann commented 11 years ago

@sschaef I'm curious, does it work for you if you change the bundle-name back to junit4?

mads-hartmann commented 11 years ago

@sschaef Ah no, sorry, you're on Kepler so it wouldn't compile with that bundle name :)

dotta commented 11 years ago

I execute them with equinox weaving but I get:

java.lang.NoClassDefFoundError: scala/tools/eclipse/logging/StreamRedirect$$anonfun$2$$anonfun$apply$2

@sschaef Looks like a binary incompatibility issue. The most likely reason is that the Scala IDE you have installed is bundled with a Scala Compiler version different than the one used to compile the Scala Search plug-in. Why is that happening? Because Scala Search uses the compiler jar, and there is no binary compatibility story for the compiler jar (only the library is binary compatible across minor versions).