search

scala-ide / scala-worksheet

A Scala IDE plugin for a multi-line REPL (called worksheet)
96 stars 24 forks source link

Preference for specifying VM arguments #128

Closed nadavwr closed 11 years ago

nadavwr commented 11 years ago

Added preference for specifying VM arguments to be used by worksheet processes. Adjusted preference page layout to accomodate for new field

dragos commented 11 years ago

@nadavwr thanks for the contribution! The build kitty is a bit confused today, hopefully I fixed the Jenkins job (again). I'll have a look at the code ASAP.

dragos commented 11 years ago

NOLITTER!

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 17165114) :cat: cleaning up... sorry! :cat:

dragos commented 11 years ago

PLS REBUILD ALL

dragos commented 11 years ago

NOLITTER!

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 17165965) :cat: Roger! Rebuilding worksheet-2.1-2.9-pr-validator, worksheet-2.1-2.10-pr-validator for 8b82f153. :rotating_light:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 17167653) :cat: cleaning up... sorry! :cat:

dotta commented 11 years ago

@nadavwr I noticed you haven't yet signed the Typesafe CLA - and we can only accept contributions from awesome hackers that signed the above linked CLA :) The process is really simple, and it can be done online using your GitHub username. Please, let us know if you have any question.

dotta commented 11 years ago

@nadavwr Could you please rebase on master (this branch can't be fully built because of a failing test - the failure is not due to your changes, and the fix for the broken test has already been merged in master).

Also, while rebasing, could you update the commit message. It's currently missing a reference to the fixed ticket. Please, have a look at our contributor doc for an example.

nadavwr commented 11 years ago

I've got a runaway commit on the pull request branch, which I've already squashed on my end. Instead of finessing it, I'll just replicate the changes, then open a new pull request from a new branch.