Scanner classes no longer need a `colorManager` - Githubissues

scala-ide / scala-worksheet

A Scala IDE plugin for a multi-line REPL (called worksheet)

96 stars 24 forks source link

Scanner classes no longer need a `colorManager` #142

Closed dotta closed 11 years ago

dotta commented 11 years ago

Updated codebase to comply with scala-ide/scala-ide@SHA: 7d846dfdb40a0dd5c5f9ab6376931d1322ef0130

(Let's try again, maybe the build kitty won't get lost this time)

dotta commented 11 years ago

NOLITTER! SYNCH! PLS REBUILD ALL!

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19006562) :cat: Roger! Rebuilding worksheet-scala-ide-stable, worksheet-scala-ide-nightly for f8cb5c01. :rotating_light:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19006562) :cat: cleaning up... sorry! :cat:

dotta commented 11 years ago

NOLITTER! SYNCH! PLS REBUILD ALL!

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19007197) :cat: Roger! Rebuilding worksheet-scala-ide-stable, worksheet-scala-ide-nightly for f8cb5c01. :rotating_light:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19007197) :cat: cleaning up... sorry! :cat:

dotta commented 11 years ago

NOLITTER! SYNCH! PLS REBUILD ALL!

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19009582) :cat: Roger! Rebuilding worksheet-scala-ide-stable, worksheet-scala-ide-3.0.x-nightly, worksheet-scala-ide-4.0.x-nightly for f8cb5c01. :rotating_light:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19009582) :cat: cleaning up... sorry! :cat:

dotta commented 11 years ago

BUILDLOG?

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 19027971) worksheet-scala-ide-stable:

f8cb5c01: error: failed: Took 64 s., pending: started., error: failed: Took 66 s., error: failed: Took 60 s., pending: started., pending: started., error: failed: Took 64 s.

worksheet-scala-ide-3.0.x-nightly:

f8cb5c01: success: Took 2 min.

worksheet-scala-ide-4.0.x-nightly:

f8cb5c01: success: Took 4 min., pending: started.

dotta commented 11 years ago

Failure against scala-ide-stable is expected. What this PR does is actually ensuring source compatibility against Scala IDE branches 4.0.x and, in particular, 3.0.x, which will be used to cut the upcoming 3.0.1 maintenance release.

dotta commented 11 years ago

This PR is up for review!

dragos commented 11 years ago

LGTM!