search

scala-ide / scala-worksheet

A Scala IDE plugin for a multi-line REPL (called worksheet)
96 stars 24 forks source link

Added keyboard shortcut to clear evaluation results #144

Closed ukstv closed 11 years ago

ukstv commented 11 years ago

New eclipse Action added.

Keyboard shortcut Ctrl+Shift+C now clears evaluation results.

Fix #132.

skyluc commented 11 years ago

NOLITTER! PLS REBUILD ALL!

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20517977) :cat: Roger! Rebuilding worksheet-scala-ide-3.0.x-nightly, worksheet-scala-ide-4.0.x-nightly for 0ccd07ca, b42e2c3c. :rotating_light:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20517977) :cat: cleaning up... sorry! :cat:

skyluc commented 11 years ago

Except for a couple of comments, this LGTM. Nice reuse of the existing code.

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20726548) :cat: Synchronaising! :pray:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20726548) :cat: cleaning up... sorry! :cat:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20726737) :cat: Roger! Rebuilding worksheet-scala-ide-3.0.x-nightly, worksheet-scala-ide-4.0.x-nightly for 0ccd07ca, b42e2c3c. :rotating_light:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20727096) worksheet-scala-ide-3.0.x-nightly:

worksheet-scala-ide-4.0.x-nightly:

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20726737) :cat: cleaning up... sorry! :cat:

skyluc commented 11 years ago

PLS SYNCH

scala-jenkins commented 11 years ago

(kitty-note-to-self: ignore 20728499) :cat: Synchronaising! :pray:

ukstv commented 11 years ago

It seems I have to merge it with the latest master again :) I will do it by the end of the week, ok?

ghprb-bot commented 11 years ago

Can one of the admins verify this patch?

dragos commented 11 years ago

ok to test

dragos commented 11 years ago

add to whitelist

dragos commented 11 years ago

retest this please

dotta commented 11 years ago

@ukstv Looks like this PR only misses a couple of really small fixes to get merged (if we don't hear from you in the next days we'll do it ourselves, it would be a shame to waste such a great contribution! :-) )

ukstv commented 11 years ago

NOLITTER! PLS REBUILD ALL!

dotta commented 11 years ago

retest this please

ghprb-bot commented 11 years ago

Test FAILed. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/19/

dotta commented 11 years ago

My bad, I've messed up the Jenkins job configuration last Friday. Should be good now. Let's give it another try.

dotta commented 11 years ago

retest this please

ghprb-bot commented 11 years ago

Test PASSed. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/20/

ghprb-bot commented 11 years ago

Test PASSed. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/21/

dotta commented 11 years ago

@ukstv I just noticed there are 4 commits... seems like something went wrong during rebasing?!

ukstv commented 11 years ago

@dotta Nothing wrong. I've done a usual merge, not a rebase. Is it a mistake maybe?

dotta commented 11 years ago

@ukstv I see. It's a merge commit + an additional commit, which was the right thing to do. Alright, the PR looks good to me. Now, I think we should proceed with squashing (one single commit should be good enough for the functionality provided in this PR), and it would be ideal if you could remove the merge commit and instead rebase on master, as it makes for a cleaner githistory - I could do this myself, in case you'd want me to do so.

ukstv commented 11 years ago

@dotta ok, I'll do it tonight.

dotta commented 11 years ago

@ukstv Thanks!

dragos commented 11 years ago

I can squash and re-issue the pull request.

dragos commented 11 years ago

@ukstv, I'm closing this one and using #155 for the merge. Thanks a lot for your contribution!