search

scala-ide / scala-worksheet

A Scala IDE plugin for a multi-line REPL (called worksheet)
96 stars 24 forks source link

Resolve compiler errors due to changes in scala-ide master #150

Closed kiritsuku closed 11 years ago

kiritsuku commented 11 years ago

This PR is required to keep source compatibility with scala-ide/scala-ide#432.

ghprb-bot commented 11 years ago

Can one of the admins verify this patch?

dragos commented 11 years ago

ok to test

dragos commented 11 years ago

add to whitelist

dragos commented 11 years ago

retest this please

dragos commented 11 years ago

retest this please

kiritsuku commented 11 years ago

This solves only compiler errors due to PR scala-ide/scala-ide#432, it is not backwards source compatible (The same as for scala-ide/scala-ide-play2#163). Both PRs can only compile when the changes in scala-ide master are merged. Is that problematic?

kiritsuku commented 11 years ago

Ok, I see now, you talked with a bot.

dragos commented 11 years ago

@sschaef sorry, yes... we're evaluating ghprb.

dragos commented 11 years ago

(can we say ghprb just passed the Turing test?)

dotta commented 11 years ago

This PR is incompatible with 3.0.x. We should do this sort of refactoring once we are close to 4.0.0 release.