Use project-specific compiler settings when evaluating a worksheet.

scala-ide / scala-worksheet

A Scala IDE plugin for a multi-line REPL (called worksheet)

96 stars 24 forks source link

Use project-specific compiler settings when evaluating a worksheet. #175

Closed dragos closed 10 years ago

dragos commented 10 years ago

No test since there is no easy way to trigger some observable effect from compiler settings, other than using compiler plugins (and continuations are missing from the 2.11 build).

-deprecation or -feature won't work because warnings are not reported (see #174)
the continuations plugin isn't part of 2.11, so tests would only work in 2.10

However, I think the integration test isn't really necessary: scalacArguments is part of sdt.core and used by the sbt builder.

Fixed #173

ghprb-bot commented 10 years ago

Test PASSed. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/31/

ghprb-bot commented 10 years ago

Test PASSed. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/33/

dotta commented 10 years ago

Did you smoke tested that compiler plug-ins are picked up? If yes, then LGTM.

dragos commented 10 years ago

Yes, I forgot to mention that. I manually tested it using the continuations plugin on 2.10, and it worked. However, new settings take effect only after a successful build (same as for classpath changes, before this PR).

huitseeker commented 10 years ago

LGTM, of course !

skyluc commented 10 years ago

:+1: I tested using -Xno-uescape. It generates pretty errors.