scala-ide / scala-worksheet

A Scala IDE plugin for a multi-line REPL (called worksheet)
96 stars 24 forks source link

More robust WorksheetsManager: don't die on unhandled exceptions. #176

Closed dragos closed 10 years ago

dragos commented 10 years ago

I noticed the worksheet manager actor died on some uncaught exceptions. This commit makes it log and continue (since it's a singleton instance in a lazy val, the only workaround is to restart eclipse). Also, noticed that closing a Scala project causes unit.scalaProject to throw, so wrapped that into a Try.

I didn't generalize this treatment because in most other cases there is no good way to recover from missing an open project.

Fixed #129

ghprb-bot commented 10 years ago

Test PASSed. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/32/

dotta commented 10 years ago

LGTM