search

scala-ide / scala-worksheet

A Scala IDE plugin for a multi-line REPL (called worksheet)
96 stars 24 forks source link

Fixed memory leak in `WorksheetsManager` #226

Closed dotta closed 9 years ago

dotta commented 9 years ago

When closing/deleting a project, the actor used to execute the worksheet was both not stopped and removed from the WorksheetsManager map. This commit fixes both issues.

ghprb-bot commented 9 years ago

Refer to this link for build results (access rights to CI server needed):

https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/99/ https://jenkins.scala-ide.org:8496/jenkins/job/worksheet-scala-ide-4.0.x-nightly/109/ Test FAILed.

ghprb-bot commented 9 years ago

Refer to this link for build results (access rights to CI server needed):

https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/100/ https://jenkins.scala-ide.org:8496/jenkins/job/worksheet-scala-ide-4.0.x-nightly/110/ Test PASSed.

ghprb-bot commented 9 years ago

Refer to this link for build results (access rights to CI server needed):

https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/101/ https://jenkins.scala-ide.org:8496/jenkins/job/worksheet-scala-ide-4.0.x-nightly/111/ Test PASSed.

dotta commented 9 years ago

The first failure seems to be due to a non deterministic test execution. Regardless, this PR is up for review!

dragos commented 9 years ago

One small thing, otherwise LGTM. Thanks for this super useful fix!

dotta commented 9 years ago

Thanks for catching that aberration. Should be good now!

ghprb-bot commented 9 years ago

Refer to this link for build results (access rights to CI server needed):

https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-worksheet-validator/102/ https://jenkins.scala-ide.org:8496/jenkins/job/worksheet-scala-ide-4.0.x-nightly/112/ Test PASSed.

dragos commented 9 years ago

Great, thanks!