search

scala-ide / scalariform

Scala source code formatter
http://scala-ide.github.com/scalariform/
MIT License
527 stars 148 forks source link

Add preferences for first parameter and arguments showing up on newlines #205

Closed jkinkead closed 8 years ago

jkinkead commented 8 years ago

Fixes https://github.com/scala-ide/scalariform/issues/202 .

Sorry - this is a big, messy one. The underlying alignment code is complicated.

This doesn't change default behavior; that can come in a future PR.

ghprb-bot commented 8 years ago

Refer to this link for build results (access rights to CI server needed): https://jenkins.scala-ide.org:8496/jenkins//job/ghprb-scalariform/29/ Test PASSed.

jkinkead commented 8 years ago

This also fixes #158 .

joan38 commented 8 years ago

Is this PR going to be merged? What is the road map for the 1.0?

jkinkead commented 8 years ago

Not being on the scala-ide team, I'm holding off on merging this until:

  1. Jenkins configuration is fixed or confirmed ignorable for PR #225
  2. PR #225 is merged
  3. I resolve the merge conflicts here & fix any updated tests

After that, it's mostly getting an integration test running to validate bugs #142 and #153 . I have that partially working, but have been lazy getting it fully-working (and these PRs were blocking that as well).

After that, I'll need to figure out the scala-ide release process. :P

joan38 commented 8 years ago

Thanks for the update @jkinkead Just for information this basically THE bug/missing feature that Intellij Idea is managing well, as well as being a Standard Scala Style, and I guess many people would like to see in. Do people agree with this?

jkinkead commented 8 years ago

Yes. This 100% will be in the final release. :)

ghprb-bot commented 8 years ago

Test PASSed.