search

scala-ide / scalariform

Scala source code formatter
http://scala-ide.github.com/scalariform/
MIT License
527 stars 148 forks source link

upgrade to ScalaTest 3.0? #232

Closed SethTisue closed 7 years ago

SethTisue commented 7 years ago

we would very much like to add scalariform back to the Scala 2.12 community build (it has been commented out for a long time), but in order for that to happen, you'd need to move to ScalaTest 3.0, which is the only version we support in the community build

Bill & co are pretty militant about providing smooth migration paths, so I assume it wouldn't be very hard, though possibly tedious. I did try simply bumping the version number, but there were compile errors.

fommil commented 7 years ago

is this also blocking releasing for 2.12?

SethTisue commented 7 years ago

Scalariform is back in the 2.12 community build now, but we aren't able to compile or run its tests. It would be better if we could.

godenji commented 7 years ago

upgrade to ScalaTest 3.0? support Scala 2.12

Done

"org.scalariform" %% "scalariform" % "0.2.0"

SethTisue commented 7 years ago

@godenji awesome! scala/community-builds@12144742518e83798572eefe8caa990233b3cd1c enables the tests again

godenji commented 7 years ago

scala/community-builds@1214474 enables the tests again

@SethTisue cool, good to hear ;-)

Just issued a PR to Scala IDE that brings embedded scalariform up-to-date with latest published version. Make Scala tooling great again! (or at least somewhat cohesive/working).