scala-ide / scalariform

Scala source code formatter
http://scala-ide.github.com/scalariform/
MIT License
527 stars 148 forks source link

WIP Add line number to the ScalaParserException. #287

Open mwz opened 4 years ago

mwz commented 4 years ago

I'm looking at fixing #104, which has an impact on Scalastyle (#319) and I'd appreciate some early feedback on the approach I've taken. This is my first time looking at this codebase, so what I'm doing here might not be a good way of solving this. Any comments would be much appreciated.

So I essentially modified scala parsers to keep track of the current line based on the count of newline characters in the current token's text from associatedWhitespaceAndComments when the nextToken function gets called. I wasn't sure if there was any better way of doing this.

This is a WIP as I want to validate whether this approach is correct before writing more tests etc.