search

scala-ide / scalariform

Scala source code formatter
http://scala-ide.github.com/scalariform/
MIT License
527 stars 148 forks source link

Scalariform should not fail on '_' in numeric literals #293

Open diversit opened 2 years ago

diversit commented 2 years ago

We change to use SonarScala plugin in SonarQube to scan our Scala code. However, the scan fails on numeric literals like 100_000L.

This is caused by the function checkNoLetter in ScalaOnlyLexer L509.

Could the checkNoLetter function be changed to not fail on _ characters in a number since this is valid Scala code?

Error

scalariform.lexer.ScalaLexerException: Invalid literal number: _

Expected Scalariform should not fail on literal numbers with _ like 150_100L.