search

scala-interop / slinc

Scala <-> C interop
GNU Affero General Public License v3.0
102 stars 5 forks source link

Sweep: write unit tests #209

Open markehammons opened 1 year ago

sweep-ai[bot] commented 1 year ago

Hey @markehammons,

Just wanted to let you know that I've started working on this issue. The plan is to create a new test file for the ReadWriteModule and add some unit tests there. I'll also be updating the CONTRIBUTING.md with some info about the importance of unit tests. If necessary, I might do a bit of refactoring in the ReadWriteModule to make it more testable.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/FSetRuntimeSpec.scala#L94-L114 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/modules/DescriptorSpec.scala#L22-L74 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/docs/_docs/contributing/contributing.md#L33-L156 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/src/fr/hammons/slinc/modules/ReadWriteModule.scala#L31-L57 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/CONTRIBUTING.md#L33-L156

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact team@sweep.dev.

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

Hey @markehammons,

I've started working on this issue. The plan is to write unit tests for the ReadWriteModule.scala file. I'll be creating a new test file ReadWriteModuleSpec.scala in the core/test/src/fr/hammons/slinc/modules/ directory for this purpose.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/FSetRuntimeSpec.scala#L94-L114 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/modules/DescriptorSpec.scala#L22-L74 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/CONTRIBUTING.md#L33-L156 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/src/fr/hammons/slinc/modules/ReadWriteModule.scala#L31-L57 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/docs/_docs/contributing/contributing.md#L33-L156

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

Hey @markehammons,

I've started working on this issue. The plan is to create a new test suite for the ReadWriteModule.scala methods. I'll be following the structure and style of tests in DescriptorSpec.scala for consistency.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/FSetRuntimeSpec.scala#L94-L114 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/modules/DescriptorSpec.scala#L22-L74 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/CONTRIBUTING.md#L33-L156 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/src/fr/hammons/slinc/modules/ReadWriteModule.scala#L31-L57 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/docs/_docs/contributing/contributing.md#L33-L156

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact team@sweep.dev.

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact team@sweep.dev.

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

Hey @markehammons,

Just wanted to let you know that I've started working on this issue. The plan is to create a new test file ReadWriteModuleSpec.scala in the core/test/src/fr/hammons/slinc/modules/ directory. This file will contain unit tests for the methods in ReadWriteModule.scala. I'll be using the existing test files like DescriptorSpec.scala and FSetRuntimeSpec.scala as a reference for writing these tests.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/FSetRuntimeSpec.scala#L94-L114 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/modules/DescriptorSpec.scala#L22-L74 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/CONTRIBUTING.md#L33-L156 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/src/fr/hammons/slinc/modules/ReadWriteModule.scala#L31-L57 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/docs/_docs/contributing/contributing.md#L33-L156

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

Hey @markehammons,

I've started working on this issue. The plan is to create a new test suite for the ReadWriteModule.scala file. This will help ensure that the methods for reading and writing data are working as expected. I'll be following the testing pattern used in other test suites in the project.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/FSetRuntimeSpec.scala#L94-L114 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/modules/DescriptorSpec.scala#L22-L74 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/CONTRIBUTING.md#L33-L156 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/src/fr/hammons/slinc/modules/ReadWriteModule.scala#L31-L57 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/docs/_docs/contributing/contributing.md#L33-L156

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact team@sweep.dev.

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact team@sweep.dev.

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

Hey @markehammons,

I've started working on this issue. The plan is to create a new test file for the ReadWriteModule and enhance the existing tests for the Descriptor and FSetRuntime modules. I'll ensure that all functionalities are properly tested.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/FSetRuntimeSpec.scala#L94-L114 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/test/src/fr/hammons/slinc/modules/DescriptorSpec.scala#L22-L74 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/CONTRIBUTING.md#L33-L156 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/src/fr/hammons/slinc/modules/ReadWriteModule.scala#L31-L57 https://github.com/scala-interop/slinc/blob/8e2ad0c132fbb9d5c7213de27dbbb6b2eebdcd48/core/docs/_docs/contributing/contributing.md#L33-L156

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

sweep-ai[bot] commented 1 year ago

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact team@sweep.dev.

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!