search

scala-js / scala-js-dom

Statically typed DOM API for Scala.js
Other
315 stars 160 forks source link

Create HTMLDialogElement #708

Closed Lasering closed 2 years ago

Lasering commented 2 years ago

Fixes #223.

Coudn't find an example of how overloaded methods are implemented in scala-js-dom. Looked at HTMLElement.focus() but it seems the case where focus receives options was not implemented.

Ran prePR without problems, was expecting prePR to edit/generate files in api-reports. What is the process to commit changes there?

armanbilge commented 2 years ago

Thanks for this!!

I think the file you added is missing the .scala extension, that's why the tooling isn't working :)

Lasering commented 2 years ago

Now it should be proper.

Lasering commented 1 year ago

@armanbilge shouldn't a type alias type Dialog = HTMLDialogElement be added here https://github.com/scala-js/scala-js-dom/blob/main/dom/src/main/scala/org/scalajs/dom/html.scala? I can make a new PR to fix it.