search

scala-js / scala-js-dom

Statically typed DOM API for Scala.js
Other
318 stars 162 forks source link

`Location#origin` should return a `String` #746

Closed armanbilge closed 1 year ago

armanbilge commented 1 year ago

There's a reason it doesn't, but it's not a particularly good one.

https://github.com/scala-js/scala-js-dom/blob/410f4392df7ea815b640cef10db3e072a6c388c8/dom/src/main/scala/org/scalajs/dom/Location.scala#L47-L49

https://developer.mozilla.org/en-US/docs/Web/API/Location/origin#browser_compatibility

armanbilge commented 1 year ago

Oh and also this flag parameter is not part of the spec, just a firefox thing ... https://github.com/scala-js/scala-js-dom/blob/410f4392df7ea815b640cef10db3e072a6c388c8/dom/src/main/scala/org/scalajs/dom/Location.scala#L55