search

scala-js / scala-js-dom

Statically typed DOM API for Scala.js
Other
315 stars 160 forks source link

Typo in "WriteableStream" trait name? #754

Open raquo opened 1 year ago

raquo commented 1 year ago

It seems that the native interface is actually called WritableStream, however Scala trait name has an extra e character in it.

I'm not familiar with this API, the trait is not JSGlobal, and I don't actually see how one could get instances of this trait in scala-js-dom, but nevertheless it should probably match the native name?

armanbilge commented 1 year ago

Thanks, this indeed seems like a mistake :( there are actually many issues with those facades, see https://github.com/scala-js/scala-js-dom/issues/629.

I don't think we can fix this binary-compatibly. Maybe we can add a type alias with the correct name.