Open yilinwei opened 1 year ago
@yilinwei is this PR ready-for-review? otherwise do you mind if we mark as draft so you can un-draft it when it's ready :)
It's not ready, I'm still slowly playing around with the APIs to make sure they're correct.
Please mark it as a draft; I didn't realise that was a feature at all!
On Tue, 26 Sep 2023, 16:55 Arman Bilge, @.***> wrote:
@yilinwei https://github.com/yilinwei is this PR ready-for-review? otherwise do you mind if we mark as draft so you can un-draft it when it's ready :)
— Reply to this email directly, view it on GitHub https://github.com/scala-js/scala-js-dom/pull/797#issuecomment-1735830629, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEE6CADCHUR3XPZBCRIU53X4L3HNANCNFSM6AAAAAA2UB4UV4 . You are receiving this because you were mentioned.Message ID: @.***>
Thank you for this! I'll find some time to review this ASAP, and we're hoping to cut a release (with this PR) sometime in January.
Thanks! I've addressed all the feedback - let me know if we've missed anything.
Thank you both a lot for this! I'll wait till @armanbilge reviewed this as well before merging, because reviewing is quite a manual task and I might have missed something.
@armanbilge would you be able to take a look when you have the chance?
This is in progress at the moment, since I have an active project which is binding to most of these methods.
I'm opening it, mainly so that there's some visibility on the changes which I'm in the progress of making.
I haven't copy-pasted the docs nor run some of the release reports yet and won't until I finish the changes.
EDIT:
This is ready for review/merging.