scala-js / scala-js-dom

Statically typed DOM API for Scala.js
Other
315 stars 160 forks source link

Add support for WebGL2 #838

Open tsnee opened 4 months ago

tsnee commented 4 months ago

This PR is an attempt to add complete support for WebGL 2 (as defined at MDN, not the official WebGL2 spec). In the course of preparing this PR I have uncovered a few inconsistencies between the two and alerted MDN.

I was advised to use Int for everything that would fit in 32 bits and Double for everything that would not, and I did my best to follow that advice, but I don't know if there is a way to verify that I did it perfectly.

Any and all comments and criticism are welcome.

zetashift commented 3 months ago

Thank you very much!!! This is amazing work. The reviewing process might be a bit slow, so please bear with us!