search

scala-js / scala-js-env-jsdom-nodejs

Node.js with jsdom environment for Scala.js
BSD 3-Clause "New" or "Revised" License
8 stars 10 forks source link

Upgrade to Scala.js 1.0.0-M7. #20

Closed sjrd closed 5 years ago

sjrd commented 5 years ago

This should set exitJSStatement now:

I don't think it should, because there is no way to exit out of a jsdom environment anymore. We used to shove something into __ScalaJSEnv, but that something is not otherwise accessible to jsdom-managed scripts. It is only available at the top-level code which controls jsdom.

gzm0 commented 5 years ago

I don't think it should, because there is no way to exit out of a jsdom environment anymore.

Good point. I assume window.close() (on all open windows) doesn't actually exit? In any case, OK to leave like this.

sjrd commented 5 years ago

Ping @gzm0 about the latest commit.

sjrd commented 5 years ago

OK, I reverted most of the changes, and deleted the dead code.

sjrd commented 5 years ago

@gzm0 Anything else here? Together with the PhantomJS env--which I'll update according to whatever design we settle on here--this is the only remaining artifact before we can really announce 1.0.0-M7.

gzm0 commented 5 years ago

Oh, dear. Sorry, somehow I kept the pending review open. Will review asap.