scala-js / scala-js-env-jsdom-nodejs

Node.js with jsdom environment for Scala.js
BSD 3-Clause "New" or "Revised" License
8 stars 10 forks source link

Fix #32: Use the new API of jsdom v10. #33

Closed sjrd closed 4 years ago

sjrd commented 4 years ago

This is a forward-port of the upstream commit https://github.com/scala-js/scala-js/commit/8d1938b6eaa985c933189f0eaf82edee0b3cb897

In this commit, we preserve the status quo of this codebase for jsdom v9. The code in 0.6.x (with the simpler virtualConsole.sendTo call) does not pass the full test suite.

However, for v10+, we use exactly the same code as in the latest Scala.js 0.6.x, coming from the above commit.

sjrd commented 4 years ago

/cc @japgolly

japgolly commented 4 years ago

Thank you!