Added an example to the README

scala-js / scala-js-env-jsdom-nodejs

Node.js with jsdom environment for Scala.js

BSD 3-Clause "New" or "Revised" License

8 stars 10 forks source link

Added an example to the README #52

Closed davesmith00000 closed 2 years ago

davesmith00000 commented 2 years ago

I found the instructions a bit magical, so I thought I'd spell out the usage a bit for the next person interested in trying it.

Based on the jsdom docs I had it in my head that I was was going to have to create a jsdom instance myself. "Is this plugin giving me a nice way to do that?" I wondered ...but after I read the source code I realised that this plugin is fully setting up node.js with a running dom instance (of course... makes much more sense 🤦 ).

Anyway I hope this helps someone.

sjrd commented 2 years ago

LGTM. Could you squash everything in a single commit with a clean commit message, please?

davesmith00000 commented 2 years ago

Done, hopefully that's better. Sorry I was a bit hasty with the first version of the PR.