search

scala-js / scala-js-website

Source for https://www.scala-js.org/
261 stars 146 forks source link

Fix the permalink for 1.5.1 #582

Closed blakehawkins closed 2 years ago

blakehawkins commented 2 years ago

This is the URI referenced in https://github.com/scala-js/scala-js-website/blob/main/doc/internals/version-history.md

gzm0 commented 2 years ago

TY for the PR. I'm assigning this to @sjrd, because I'm not 100% familiar with how these links are used / generated (I'd like to avoid removing an existing, incorrect permalink accidentally).

blakehawkins commented 2 years ago

The existing link is already a 404 so I think this PR doesn't actually add any exposure as-is

I'm happy to add a permalink redirect in any fase

sjrd commented 2 years ago

The existing URL https://www.scala-js.org/news/2020/11/16/announcing-scalajs-1.5.1/ is clearly not a 404. So if we move that page, we do need a redirect. 😉

blakehawkins commented 2 years ago

Yeah fair enough, assuming someone managed to get to that URI!

gzm0 commented 2 years ago

It's very likely in a tweet somewhere :))