search

scala-jsonapi / scala-jsonapi

Scala support library for integrating the JSON API spec with Spray, Play! or Circe
Other
107 stars 29 forks source link

Allow null as value to represent no values for optionals in spray-json formatter #95

Closed alanwguo closed 7 years ago

alanwguo commented 7 years ago

closes #94

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.007%) to 95.878% when pulling 3d34df638ebed83e27349cbd7862ddec913b7c42 on alanwguo:master into 1857ff3270bcd04488366cfe32acca95e6d8b780 on zalando:master.

codecov-io commented 7 years ago

Codecov Report

Merging #95 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   96.58%   96.59%   +<.01%     
==========================================
  Files          17       17              
  Lines         557      558       +1     
==========================================
+ Hits          538      539       +1     
  Misses         19       19
Impacted Files Coverage Δ
.../jsonapi/json/sprayjson/SprayJsonReadSupport.scala 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1857ff3...3d34df6. Read the comment docs.

oporkka commented 7 years ago

@zmeda what do you think?